feat: move images to assets directory #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldenmaya
requested review from
Andrew-Orlov,
ivan-kalachikov and
NaMax66
and removed request for
a team
NaMax66
requested changes
Dec 18, 2024
| @@ -175,9 +176,11 @@ function print() { | |||
| .map((el) => el.outerHTML) | |||
| .join(""); | |||
|
|
|||
| const logoImage = loadImage(logoUrl.value!); | |||
| @@ -0,0 +1,11 @@ | |||
| export function loadImage(fileName: string): string { | |||
| return new URL(`/client-app/assets/icons/basic/${name}.svg`, import.meta.url).href ?? ""; | ||
| } | ||
|
|
||
| export function isFilenameOnly(src: string): boolean { |
| } | ||
|
|
||
| export function loadIcon(name?: string): string { | ||
| return new URL(`/client-app/assets/icons/basic/${name}.svg`, import.meta.url).href ?? ""; |
There was a problem hiding this comment.
dependent from client-app.
add task to make it init phase settings. or move all images to ui kit folder
There was a problem hiding this comment.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2041
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.12.0-pr-1506-9710-9710ab91.zip